#128 ✓hold
Kieran P

Quick Add Tags functionality failing for some users

Reported by Kieran P | December 9th, 2008 @ 12:32 PM | in 1.2

A weird issue where adding a tag using the short cut method in the side-bar as a user other than a topic creator seemed to fail occasionally.

i.e. you'd click add an nothing would happen

It might also be related to tags with spaces in their names

Comments and changes to this ticket

  • James

    James December 9th, 2008 @ 01:23 PM

    The steps to reproduce were are follows:

    1. Set up Kete and create a new topic as usual
    2. Add a tag via the quick side-bar UI
    3. Register as a new user
    4. Add a second tag with a space in the name via the quick side-bar UI
    5. Notice the new tag fails to appear

    You may need to use IE 6 to reproduce the issue.

    If these steps do not replicate the issue, please mark as invalid and note that you could not replicate.

    Cheers, James

  • Kieran P

    Kieran P December 12th, 2008 @ 02:10 PM

    • State changed from “new” to “invalid”

    Unable to replicate on the most recent copy of Kete master. Possibly fixed already. Reopen the ticket if this happens again.

  • Walter McGinnis

    Walter McGinnis December 15th, 2008 @ 02:50 PM

    • State changed from “invalid” to “open”

    Don't close this ticket until you have added a test that attempts to replicate it. This will require us to finish the Selenium testing set up, of course.

    Cheers, Walter

  • Kieran P

    Kieran P January 22nd, 2009 @ 11:05 AM

    There are tests for the non JS quick tag adding functionality in master branch now. As for the JS tests, the selenium in webrat still needs some polishing (particularly with a method called wait_for).

  • Kieran P

    Kieran P January 22nd, 2009 @ 12:30 PM

    • State changed from “open” to “hold”

    When Selenium testing is possible (the final issues I'm getting are resolved), then the following tests would need to be implemented:

    • Test adding a new tag work successfully and updates the flash message and updates the tag list
    • Test leaving the field blank does not send a post request
    • Test a failing tag updates the flash message with what went wrong (you may need to redefine the tag model to add a validation)
    • Test that when a new tag is added, a comment is added to the update so it shows up on the history page
    • Test that the history page is still working after several tags are added (i.e. versions<->contributors still match up)
    • Test that the cache is cleared in production mode when a new tag is added (refresh the page after adding and check)

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket