#146 ✓resolved
Kieran P

Gem building support for Managegems rake task

Reported by Kieran P | January 5th, 2009 @ 09:53 AM | in 1.2

At the moment, the manage gems rake task only supports pre build gems so if you need a gem not prebuilt, you have to do it manually.

Add support for the rake task to clone, build, and install gem sources, with necessary commands and dependancies for building checked and installed.

Comments and changes to this ticket

  • Kieran P

    Kieran P January 5th, 2009 @ 09:55 AM

    • Milestone set to 1.2
    • Assigned user changed from “Kete” to “Kieran P”
    • Title changed from “Gem building support for Manage Gems rake task” to “Gem building support for ”
  • Kieran P

    Kieran P January 5th, 2009 @ 09:56 AM

    • Tag set to manage gems, gems, rake, testing
    • Title changed from “Gem building support for ” to “Gem building support for Managegems rake task”

    (mistakenly hit enter key which reset title ^_^ )

  • Kieran P

    Kieran P January 5th, 2009 @ 11:01 AM

    • State changed from “new” to “to-review”

    This work has been pushed to a branch and is ready for review:

    refinement_lh146_gem_building_support

    http://github.com/kete/kete/comm...

    Basically, if a gem repo is set, it assumes you want to build the gem.

    I've also pulled out nokogiri and selenium-client gems from the required libs and made them webrat dependencies (which they are). This means they won't be included twice anymore (once using our load_testing_libs method, and later on from within webrat).

    Also added a pre_command setting, to run something before installing/building gems (like removing old webrat/piston installations).

    IIRC, this might come in handy with libxml-ruby. Anything higher than version 0.7.0 breaks Kete.. so we could add a line to the libxml-ruby to remove all versions before installing the 0.7.0 (to make sure things work). Might break other apps using libxml-ruby > 0.7.0 though. Thoughts?

  • Walter McGinnis

    Walter McGinnis January 5th, 2009 @ 11:16 AM

    Hi Kieran

    Nice work. Commit looks good. Have you tested that existing
    functionality still works? I.e. a the other rake tasks still function?

    In the future, we'll want assess whether to use other tools than back
    ticks to specify command line calls. Something to keep an eye out for
    a best practice of. There are quite a number of things we can do to
    make our command line calls more ruby like I think. I don't want to
    rewrite this now though. Capistrano has some good example code usually.

    The redundancy of the gem_deps to a gem's gemspec rubs me a little
    wrong, but I'll live with it.

    As far as libxml, do you recall what broke when we used a later version?

    Cheers, Walter

    On Jan 5, 2009, at 11:01 AM, Lighthouse wrote:

  • Kieran P

    Kieran P January 5th, 2009 @ 11:47 AM

    Have you tested that existing functionality still works? I.e. a the other rake tasks still function?

    Yes, required, testing, and management rake tasks still functioning properly.

    As far as libxml, do you recall what broke when we used a later version?

    IIRC, it was complaining about undefined method find somewhere in the zoom plugin. Guess they removed it without warning (I didn't see any deprecation warnings).

  • Kieran P

    Kieran P January 5th, 2009 @ 01:17 PM

    • State changed from “to-review” to “resolved”

    Work has been merged into master branch. Resolving ticket.

  • Walter McGinnis

    Walter McGinnis January 7th, 2009 @ 02:47 PM

    All good. Go ahead and merge to master.

    Please open a separate ticket for libxml-ruby compatibility. It might
    be relatively straightforward to get it going and from my
    understanding there is a big speed advantage with newer versions.

    Cheers, Walter

    On Jan 5, 2009, at 11:47 AM, Lighthouse wrote:

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket

Pages