#200 new
Walter McGinnis

Restore action slow

Reported by Walter McGinnis | May 13th, 2009 @ 11:16 AM | in 1.4

When restoring a topic to a previous version, the action took 27 seconds under 1.2. It had only 4 versions.

Investigate why this is slow and optimize.

Comments and changes to this ticket

  • Kieran P

    Kieran P May 13th, 2009 @ 12:32 PM

    Part of the time is probably spent parsing the xml into a hash. XML generation was switched to Nokogiri, but reading XML still uses the old REXML/XmlSimple.in method, which is probably causing some of the slowness.

    However, our XML is invalid, so when trying to switch from REXML to Nokogiri, Nokogiri is having trouble parsing it (because we use numeric keys which are invalid in XML, the document doesn't parse correctly).

    It would be nice if Nokogiri supported invalid XML like this, but at some point, we'll want to convert existing XML to be valid.

  • Walter McGinnis

    Walter McGinnis November 28th, 2011 @ 03:45 PM

    • Milestone changed from 1.3 to 1.4
    • Milestone order changed from “0” to “0”

    This could be rolled into an update of the UI to be a lightbox rather than a popup.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket

Pages