#223 ✓resolved
Walter McGinnis

Location persists in "view on map" despite "do not record location"

Reported by Walter McGinnis | August 13th, 2009 @ 04:07 PM | in 1.3 (closed)

If an item has had a location recorded in a previous version, perhaps by mistake, but a version is added with "do not record location" set instead, the old location will still show up in result pages "view on map".

Note that no map is shown on the item's detail page.

I suspect that even though the "do not record location" is being saved, the location data is also maintained. Display logic on item detail page prevents the bad location from being displayed, but it is still making it into the zebra oai dc record.

Comments and changes to this ticket

  • Kieran P

    Kieran P August 14th, 2009 @ 02:23 PM

    • State changed from “new” to “resolved”

    Your suspicion was correct. I've added a very simple if conditional to exclude Google Map data if they have ticked 'do not record location'. I've manually tested that it is now working as it should. This will require sites using Google Map Extended fields to rebuild search engines.

    Resolving ticket.

  • Walter McGinnis

    Walter McGinnis August 14th, 2009 @ 02:39 PM

    So no location data is in the current version of the item and its oai-
    pmh record after the user submitted it with "don't record" for
    location value? Or are you saying the conditional is on the
    presentation end?

    The cleaner solution is to make sure the data doesn't persist with the
    item.

  • Kieran P

    Kieran P August 14th, 2009 @ 02:45 PM

    The data is stored on database regardless of whether they choose 'do not record location'. This has been the case since it was created, and looking back, while I think it would have been better to clear the field completely, it would require some changes to the system to remove, which would take time, lots of testing, any may break some cases (where we can't test with integrations because they use too much Javascript).

    So I've done a quick one line fix for now (until something else is done).

    So now the data is not shown on the item pages (as has always been the case), and now no longer reaches zebra if 'do not record location' is set.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket

Pages