Theme selector UI not consistent with currently selected theme
Reported by James | August 18th, 2008 @ 10:46 AM | in 1.1
When editing basket appearance preferences, the currently selected theme (if there is more than one theme installed) can often be ignored. For instance, a theme other than the one previously chosen will have the radio button checked. This is a problem because if the admin doesn't manually re-select the intended theme, the theme will change when saving the appearance settings.
To reproduce:
- Set up a Kete with several themes
- Choose a theme in a basket
- Save appearance settings
- Re-enter the appearance settings
- Notice that the previously selected theme is now not selected, and that another theme is
I think it is quite likely this bug exists in the UI logic.
It is also possible that the theme listed last is always selected, although I have not confirmed this.
Comments and changes to this ticket
-
Kieran P August 18th, 2008 @ 03:00 PM
The radio_button_tag wasn't being passed a selected value. I've quickly added this and it appears working again.
Bugfix is available in the branch bugfix_lh_num_35_selected_enabled_theme_incorrect on Github.
Changelog at http://github.com/kete/kete/comm...
-
Kieran P August 20th, 2008 @ 09:37 AM
- State changed from “new” to “open”
- Assigned user changed from “Kete” to “Kieran P”
- Milestone set to “1.1”
-
James August 20th, 2008 @ 10:16 AM
- State changed from “open” to “resolved”
I have verified this works and merged to master.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.
Kete