#39 ✓resolved
James

Standard Kete topics contain an invalid ID attribute

Reported by James | August 21st, 2008 @ 09:53 AM

Standard topics in Kete (i.e. Topics with IDs 1 through 14) contain a HTML DIV tag with the ID attribute set to "container".

This is invalid as the ID "container" is already used elsewhere in the main template and is present on every page (except perhaps error pages).

This is a problem because:

  1. It renders the XHTML for the default topic show pages and Kete home-page invalid.
  2. It causes layout problems where styles are applied to #container.

Cheers, James

Comments and changes to this ticket

  • Walter McGinnis

    Walter McGinnis August 21st, 2008 @ 10:10 AM

    A decent amount of these topics are used as "basket homepage topics" where the basket is set to only show the homepage topic rather than homepage topic + sidebar.

    Something to keep in mind when cleaning things up.

    Cheers, Walter

    On Aug 21, 2008, at 9:54 AM, Lighthouse wrote:

  • James

    James August 21st, 2008 @ 10:55 AM

    Thanks for the info Walter,

    It's still an issue because the basket home-page template uses ID=container elsewhere, therefore there is still a duplicate ID in the page.

    Cheers, James

    On 21/08/2008, at 10:10 AM, Lighthouse wrote:

  • Walter McGinnis

    Walter McGinnis August 21st, 2008 @ 11:20 AM

    Yep, I wasn't saying it wasn't an issue in any of the cases. Just pointing out that you make sure that replacing it with something valid doesn't break certain layouts that maybe based on it.

    In other words, any solution should take this particular case into account.

    As a side note, at some point we should review the contents of those default topics and update them to remain relevant.

    Cheers, Walter

    On Aug 21, 2008, at 10:55 AM, Lighthouse wrote:

  • James

    James August 21st, 2008 @ 11:40 AM

    Ok point taken re. templates that might rely on the content ID being present in the default topics.

    I can't see a particularly easy to deal with that though, because regardless I need to change the ID to somewhere, which will break templates if they are specifying CSS for #container and expecting it to be present twice or present in the content of the default topics.

    I think it might be best if I fix this issue now and then address any template issues on a case-by-case basis as Ketes are upgraded.

    Cheers, James

    On 21/08/2008, at 11:20 AM, Lighthouse wrote:

  • Walter McGinnis

    Walter McGinnis August 21st, 2008 @ 11:50 AM

    Sounds good to me. Fixing the source HTML in the default topics (i.e. the db/bootstrap/*.yml) should be done ASAP. You may have to add another class to the base.css to handle the case of a default topic being a basket homepage topic, etc.

    Cheers, Walter

    On Aug 21, 2008, at 11:40 AM, Lighthouse wrote:

  • James

    James August 27th, 2008 @ 11:09 AM

    • State changed from “new” to “resolved”

    I have replaced ID=container with ID=topic-content in cases where it was present in the bootstrap topics.

    Fixed in http://github.com/kete/kete/comm...

    Cheers, James

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket

Pages