#62 ✓resolved
Kieran P

Implement a basket specific “contact” link

Reported by Kieran P | September 22nd, 2008 @ 03:18 PM | in 1.2

A basket specific “contact” link will be made available to send a message to basket administrators without disclosing their email addresses from basket homepages.

Comments and changes to this ticket

  • Walter McGinnis

    Walter McGinnis October 30th, 2008 @ 11:26 AM

    Hi,

    I reviewed the enhancement_rt_num_4499_basket_admin_contact_form last night. Generally looks good. I merged in master and made some slight changes.

    The last thing I would suggest is that there is some code in enhancement_rt_num_4499_basket_admin_contact_form and enhancement_rt_4641_contact_user_form that can be rolled into a module and called as a mix in rather than repeated. With my changes in enhancement_rt_num_4499_basket_admin_contact_form, you can also use the same entire templates.

    So please, redo both branches so as to DRY things up (develop module in enhancement_rt_num_4499_basket_admin_contact_form and then merge that branch into enhancement_rt_4641_contact_user_form_) and use the same interface conventions as I have added:

    • "Contact the_basket_name" rather than "Contact this basket's administrators"... so "Contact Walter McGinnis" rather than "Contact this user"
    • use more specific non-jargon language when possible, for example "message" is better than "body"

    Also, keep and eye out for code that should be refactored based on stuff you have have learned via other code reviews. "get_basket_administrators" method naming for example.

    Let me know if you have questions.

    Cheers, Walter

  • Kieran P

    Kieran P November 18th, 2008 @ 09:06 AM

    • State changed from “new” to “resolved”

    Work has been merged into master. Resolving ticket.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket

Pages