#79 ✓resolved
James

File attachment paths for audio recordings and videos are invalid

Reported by James | October 7th, 2008 @ 04:05 PM

Summary

File paths for audio recordings and videos attached files are not valid.

For instance, AudioRecording#full_filename might point to public/audio_recordings/../x when it should point to public/audio/../x.

Background

ItemPrivacy::AttachmentFuOverload#full_filename, which was introduced to ensure private files went in private/ instead of public/, incorrectly assumes that files will be stored under the AttachmentFu plugin's default path of #{privacy_folder}/#{self.table_name}/../x.

This incorrect assumption only affects the files of audio recordings and videos as these have options passed to has_attachment which specify the location of the files.

Solutions

There are two possible solutions:

a) Improve ItemPrivacy::AttachmentFuOverload#full_filename to take into account the :file_system_path option when deciding where files should be saved

b) Change where audio files are saved to (for example) public/audio/ to public/audio_recordings/, and the same for video files

Comments and changes to this ticket

  • James

    James October 16th, 2008 @ 03:27 PM

    • State changed from “new” to “open”
    • Tag changed from 500, bug, correctness, deployment, error, files, inconsistent, logic, privacy to 500, bug, correctness, deployment, error, files, inconsistent, logic, privacy

    Just for anyone following along, changes to Kete are in the works that put solution (a) outlined in the ticket into effect.

    Cheers, James

  • James

    James October 20th, 2008 @ 01:19 PM

    • State changed from “open” to “resolved”

    This issue has now been resolved.

    Please refer to http://github.com/kete/kete/comm... for change details.

    IMPORTANT: The changeset added to fix this issue may require extra upgrade steps to be taken on existing Kete instances. Please see http://github.com/kete/kete/tree... for full upgrade instructions.

    Cheers, James

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket

Pages