#81 ✓resolved
Kieran P

Adding abbr attributes to all table header cells

Reported by Kieran P | October 9th, 2008 @ 01:32 PM | in 1.2

Conduct a through search for locations where table header cells do not contain ABBR attributes, and add appropriate ABBR attributes to those cells.

Comments and changes to this ticket

  • Walter McGinnis

    Walter McGinnis October 17th, 2008 @ 12:34 PM

    Just links for the standard and good practice.


    Here's good practice:


    What is in the branch does seem to follow the convention of just using the first word... except in column names generated from column_name.human_name case.

    It seems to me that we want to be smarter here, obviously the abbr value needs to unique per table, so simple truncation to first word probably isn't enough. See if you can come up with a solution that truncates to the smallest set of words to describe the column uniquely.

    Cheers, Walter

  • Kieran P

    Kieran P October 19th, 2008 @ 07:12 PM

    • State changed from “new” to “open”

    Those fields aren't actually viewable. They're all in pages like /site/images/list, but the default actions for all of those pages is to call index. And the default for index is to call redirect_to_search_for. So there is no way to get to these pages in the first place, that I can see anyway.

  • Walter McGinnis

    Walter McGinnis October 20th, 2008 @ 10:46 AM

    Ok, so if they are unused, should we remove those templates instead of modifying them?

    Could you list the templates in question here please?

    Cheers, Walter

  • Kieran P

    Kieran P October 20th, 2008 @ 10:55 AM

    audio/list.rhtml image/list.rhtml topic/list.rhtml video/list.rhtml web_link/list.rhtml

    It wouldn't hurt to remove them. The list actions in the controllers themselves also just use index as well (list is only used for active scaffold stuff?)

    On 20/10/2008, at 10:46 AM, Lighthouse wrote:

  • Walter McGinnis

    Walter McGinnis October 20th, 2008 @ 11:05 AM

    Ok, that confirms what I thought.

    Yes, remove them. There basically a hold over from early development. Having the around is just confusing and unnecessary code maintenance.

    We do use list in other controllers besides admin stuff, if IIRC (thinking baskets and moderate), but it is relatively rare.

    Cheers, Walter

    On Oct 20, 2008, at 10:55 AM, Lighthouse wrote:

  • Kieran P

    Kieran P October 20th, 2008 @ 04:37 PM

    • State changed from “open” to “resolved”

    The above work has been finished and merged into master. Resolving ticket.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.

People watching this ticket